-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement running tests against existing invocation #1401
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvdbeek
force-pushed
the
exisiting_invocation
branch
from
October 30, 2023 18:52
18ce0b1
to
d97057a
Compare
nsoranzo
reviewed
Oct 30, 2023
Co-authored-by: Nicola Soranzo <[email protected]>
mvdbeek
force-pushed
the
exisiting_invocation
branch
from
October 31, 2023 06:13
1b8a76e
to
dce6b5b
Compare
mvdbeek
force-pushed
the
exisiting_invocation
branch
from
October 31, 2023 08:24
dce6b5b
to
86341a6
Compare
nsoranzo
reviewed
Nov 1, 2023
planemo/runnable.py
Outdated
return definition_to_test_case(tests_path=tests_path, runnable=runnable) | ||
|
||
|
||
def definition_to_test_case(tests_path, runnable): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add type annotation here please?
nsoranzo
approved these changes
Nov 1, 2023
Youhou ! Thanks @mvdbeek |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1290